Skip to content

Adding in a bit more error handling for pipelines and slack reporting where available#125

Merged
ialarmedalien merged 5 commits intodevelopfrom
add_reporting_better_error_catching
Apr 10, 2026
Merged

Adding in a bit more error handling for pipelines and slack reporting where available#125
ialarmedalien merged 5 commits intodevelopfrom
add_reporting_better_error_catching

Conversation

@ialarmedalien
Copy link
Copy Markdown
Collaborator

… where available

  • use s3 instead of minio
  • add in tests for s3 transactions

ialarmedalien and others added 3 commits April 9, 2026 14:52
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
@ialarmedalien ialarmedalien force-pushed the add_reporting_better_error_catching branch from b603da8 to 6ca6256 Compare April 9, 2026 23:08
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 22.83951% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.76%. Comparing base (baa52a7) to head (846aee5).
⚠️ Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
src/cdm_data_loaders/utils/s3.py 14.48% 124 Missing ⚠️
src/cdm_data_loaders/parsers/uniprot/idmapping.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #125      +/-   ##
===========================================
- Coverage    53.09%   52.76%   -0.33%     
===========================================
  Files           63       63              
  Lines         3008     3059      +51     
===========================================
+ Hits          1597     1614      +17     
- Misses        1411     1445      +34     
Files with missing lines Coverage Δ
src/cdm_data_loaders/pipelines/core.py 98.27% <100.00%> (+0.49%) ⬆️
src/cdm_data_loaders/pipelines/cts_defaults.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/parsers/uniprot/idmapping.py 79.54% <50.00%> (ø)
src/cdm_data_loaders/utils/s3.py 14.48% <14.48%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa52a7...846aee5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ialarmedalien ialarmedalien merged commit c50a945 into develop Apr 10, 2026
11 of 13 checks passed
@ialarmedalien ialarmedalien deleted the add_reporting_better_error_catching branch April 10, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant