This repository was archived by the owner on Nov 27, 2023. It is now read-only.
fix(Visualization): position after dropping the first node. #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-archive#1010)" This reverts commit a408a13.
mmelko
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #1139 +/- ##
==========================================
+ Coverage 48.43% 48.75% +0.32%
==========================================
Files 51 51
Lines 1627 1610 -17
Branches 364 357 -7
==========================================
- Hits 788 785 -3
+ Misses 793 781 -12
+ Partials 46 44 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
kahboom
reviewed
Jan 20, 2023
| const [isPanelExpanded, setIsPanelExpanded] = useState(false); | ||
| const [, setReactFlowInstance] = useState(null); | ||
| const reactFlowWrapperRef = useRef<HTMLDivElement>(null); | ||
| const reactFlowWrapper = useRef(null); |
There was a problem hiding this comment.
this was a part of the reverting the PR: https://github.com/KaotoIO/kaoto-ui/pull/1010/files#diff-20fc6180949d2fcf17d991cc62c6be55e572335ea16c00c805dcf3c7a8a6089dL38
kahboom
approved these changes
Jan 20, 2023
mmelko
added a commit
to mmelko/kaoto-ui
that referenced
this pull request
Jan 23, 2023
…chive#1139) * Revert "fix(Visualization): Initial node isn't always centered (kaoto-archive#1010)" This reverts commit a408a13. * fix(Visualisation): tweak centering of the initial node fix kaoto-archive#1096
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix #1096 I had to revert #1010 and then tweak default Viewport configuration.