Merged
Conversation
krisztianfekete
requested review from
EItanya,
ilackarms and
yuval-k
as code owners
Signed-off-by: krisztianfekete <git@krisztianfekete.org>
krisztianfekete
force-pushed
the
chore/remove-default-endpoints
branch
from
b2f2742 to
d13ddd7
Compare
EItanya
approved these changes
Jan 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes default OpenTelemetry (OTel) endpoint configurations that were previously set to http://host.docker.internal:4317. The purpose is to avoid inadvertently overriding OTel endpoint settings that other projects might configure during initialization, as these values are propagated by the controller to any Agent it creates.
Changes:
- Unset OTel tracing exporter endpoint from hardcoded default to empty string
- Unset OTel logging exporter endpoint from hardcoded default to empty string
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we set OTel endpoint by default, which will be picked up by the controller and will be propagated into any Agent created by the controller.
This PR unsets these to avoid confusion and overriding what other projects might set during initialization.