This repository was archived by the owner on Jan 9, 2026. It is now read-only.
fixes #1346, parsing of diff-time as property#1349
Merged
Conversation
rsoeldner
requested review from
emilypi,
jmcardon and
jwiegley
as code owners
emilypi
approved these changes
Feb 26, 2024
imalsogreg
approved these changes
Feb 29, 2024
Contributor
imalsogreg
left a comment
imalsogreg
left a comment
There was a problem hiding this comment.
Robert walked me through this on a call. It looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds parsing of the property
diff-time.closes #1346
PR checklist:
cabal run tests. If they pass locally, docs are generated.pact -t), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: