Skip to content
This repository was archived by the owner on Jan 9, 2026. It is now read-only.

Lars/remove ghcjs support#1280

Merged
larskuhtz merged 2 commits intomasterfrom
lars/remove-ghcjs-support
Aug 15, 2023
Merged

Lars/remove ghcjs support#1280
larskuhtz merged 2 commits intomasterfrom
lars/remove-ghcjs-support

Conversation

@larskuhtz
Copy link
Copy Markdown
Contributor

This PR doesn't change any existing code logic. The PR

  • removes inaccessible code guarded by impl(ghcjs) and ghcjs_HOST_OS.
  • cleans up pact.cabal
  • merges modules from src-ghc into src

@larskuhtz larskuhtz force-pushed the lars/remove-ghcjs-support branch from a3443d0 to e570f7d Compare August 14, 2023 19:31
Copy link
Copy Markdown
Member

@rsoeldner rsoeldner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks good to me. Thank you Lars 👍 . A few stylistic changes (e.g. # ifdef to #ifdef) which accounts for the amount of changed lines

@larskuhtz larskuhtz merged commit ebd4a27 into master Aug 15, 2023
@larskuhtz larskuhtz deleted the lars/remove-ghcjs-support branch August 15, 2023 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants