This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Vendor sources of prettyprinter-1.6.0#1263
Merged
Conversation
larskuhtz
requested review from
emilypi,
jmcardon,
jwiegley and
sirlensalot
as code owners
larskuhtz
commented
Jul 28, 2023
vendored/prettyprinter-1.6.0/src/Data/Text/Prettyprint/Doc/Render/Terminal.hs
Outdated
Show resolved
Hide resolved
jwiegley
reviewed
Jul 31, 2023
|
|
||
| -- servant-0.20 does not yet support aeson-2.2 | ||
| -- | ||
| constraints: aeson <2.2 |
Contributor
There was a problem hiding this comment.
Is this change unrelated to the prettyprinter vendoring?
Contributor
Author
There was a problem hiding this comment.
It is related because the bound on prettyprinter indirectly implied aeson <2.2
emilypi
approved these changes
Aug 1, 2023
Contributor
emilypi
left a comment
emilypi
left a comment
There was a problem hiding this comment.
LGTM thank you @larskuhtz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendor relevant files from prettyerinter-1.6.0. This is a prerequisite for the of mtl-2.3 and latest pact master in chainweb.
As a side effect of the PR, the source-repository-package pin on trifecta can be dropped. It also removes implicit upper bounds on a number of other dependencies like optparse-applicative and configuration tools.
PR checklist:
There are no actual code changes (the code from prettyerinter is copy and pasted without changes, only outdated CPP guarded code is removed) and no behavior changes.
However, due to the implied upgrade of the trifecta version, we have to double check that main net history replay still is not broken, which will be done for the corresponding chainweb-node PR.
Confirm replay/back compat
Mainnet replay succeeded on mtl-2.3 chainweb-node#1709