This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Conversation
jmcardon
commented
Jun 27, 2023
imalsogreg
reviewed
Jun 27, 2023
imalsogreg
reviewed
Jun 27, 2023
imalsogreg
reviewed
Jun 27, 2023
imalsogreg
reviewed
Jun 27, 2023
imalsogreg
reviewed
Jun 27, 2023
imalsogreg
reviewed
Jun 27, 2023
imalsogreg
reviewed
Jun 27, 2023
imalsogreg
reviewed
Jun 27, 2023
imalsogreg
reviewed
Jun 27, 2023
0xd34df00d
approved these changes
Jul 7, 2023
Contributor
0xd34df00d
left a comment
0xd34df00d
left a comment
There was a problem hiding this comment.
Just some very minor nits, please feel free to ignore any of them!
emilypi
reviewed
Jul 10, 2023
jwiegley
reviewed
Jul 26, 2023
jwiegley
reviewed
Jul 26, 2023
jwiegley
reviewed
Jul 26, 2023
| initEvalEnv ls = do | ||
| mv <- newMVar ls | ||
| gasRef <- newIORef 0 | ||
| gasRef <- newIORef mempty |
Contributor
There was a problem hiding this comment.
If this is because it's newtype-wrapped, then ignore this and all related comments.
emilypi
reviewed
Jul 31, 2023
Contributor
emilypi
left a comment
emilypi
left a comment
There was a problem hiding this comment.
Epic work, small comment on last pass, but optional. LGTM.
emilypi
approved these changes
Aug 2, 2023
jwiegley
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a change primarily to our units of gas, wherein 1
Gas= 1000MilliGas. With our current gas metering, we have 1Gas= 2500 ns, thus, 1MilliGas= 2.5 ns.PR checklist:
cabal run tests. If they pass locally, docs are generated.pact -t), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: