Skip to content
This repository was archived by the owner on Jan 9, 2026. It is now read-only.

replace cryptonite by crypton#1240

Merged
emilypi merged 1 commit intomasterfrom
lars/crypton
Jul 11, 2023
Merged

replace cryptonite by crypton#1240
emilypi merged 1 commit intomasterfrom
lars/crypton

Conversation

@larskuhtz
Copy link
Copy Markdown
Contributor

This is supposed to not change the actual code, because crypton is a copy of cryptonite.

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

Copy link
Copy Markdown
Contributor

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't require replay because this should be a code for code replica fork at this point.

@emilypi
Copy link
Copy Markdown
Contributor

emilypi commented Jul 10, 2023

@jwiegley Replay passes for the branch pact-crypton-migration on chainweb-node: https://github.com/kadena-io/chainweb-node/actions/runs/5467897926/jobs/9955358526. Can we get this in?

@emilypi emilypi merged commit 97b0f78 into master Jul 11, 2023
@emilypi emilypi deleted the lars/crypton branch July 11, 2023 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants