Skip to content
This repository was archived by the owner on Jan 9, 2026. It is now read-only.

Flag to disable return RTC, 4.7.1 release prep#1231

Merged
sirlensalot merged 12 commits intomasterfrom
rsoeldner/rollback-tc-v47
May 20, 2023
Merged

Flag to disable return RTC, 4.7.1 release prep#1231
sirlensalot merged 12 commits intomasterfrom
rsoeldner/rollback-tc-v47

Conversation

@rsoeldner
Copy link
Copy Markdown
Member

@rsoeldner rsoeldner commented May 18, 2023

This PR mainly puts changes introduced in a33ebb8 under the DisableRuntimeReturnTypeChecking flag.

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

@rsoeldner rsoeldner changed the title Revert "[FORK] Add runtime type check for function return types (#1209)" Release Pact 4.7.1 May 18, 2023
@emilypi
Copy link
Copy Markdown
Contributor

emilypi commented May 18, 2023

I wouldn't directly revert the commit, just change the flag entry for this particular change to something like FlagDisableReturnTypeTC, and then when we go to hook it up into Chainweb, we can not use that flag.

@emilypi emilypi marked this pull request as ready for review May 18, 2023 19:04
Copy link
Copy Markdown
Contributor

@sirlensalot sirlensalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with small fix

Co-authored-by: Stuart Popejoy <[email protected]>
### Formal Verification

- Fixed empty list type defaulting to any (#1224)
- Fixed partial biniding (#1127)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed partial biniding (#1127)
- Fixed partial binding (#1127)

@sirlensalot sirlensalot changed the title Release Pact 4.7.1 Flag to disable return RTC, 4.7.1 release prep May 20, 2023
@sirlensalot sirlensalot merged commit 456aa65 into master May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants