Conversation
|
Some comments via the new template:
Didn't see this in the description
This actually means it does need a replay as any fork could have a bug. |
jwiegley
left a comment
There was a problem hiding this comment.
This looks very straightforward to me. Thank you for the tests!
Fixed, sorry I thought i pasted it
Ah, oops. Yeah it is a semantic change |
src/Pact/Native/Internal.hs
Outdated
| isExecutionFlagSet FlagDisablePact47 >>= \case | ||
| True -> | ||
| evalError' i $ "No such key in message: " <> pretty k | ||
| False -> | ||
| failTx' i $ "No such key in message: " <> pretty k |
There was a problem hiding this comment.
Optional suggestion:
| isExecutionFlagSet FlagDisablePact47 >>= \case | |
| True -> | |
| evalError' i $ "No such key in message: " <> pretty k | |
| False -> | |
| failTx' i $ "No such key in message: " <> pretty k | |
| ifExecutionFlagSet FlagDisablePact47 | |
| (evalError' i $ "No such key in message: " <> pretty k) | |
| (failTx' i $ "No such key in message: " <> pretty k) |
PR checklist:
Additionally, please justify why you should or should not do the following:
Forked. Needs replay
No point in this PR.