This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Merged
Conversation
Contributor
|
Thank you for taking the time to factor this out, @edmundnoble. Most of it looks entirely mechanical and straightforward, a clear improvement. I'll review the other bits tomorrow, if my review is still needed then. |
rsoeldner
approved these changes
May 9, 2023
Member
rsoeldner
left a comment
rsoeldner
left a comment
There was a problem hiding this comment.
This PR increases clarity, thank you 👍
| sysModuleCmd `succeedsWith` (`shouldBe` textVal "system module loaded") | ||
| acctModuleCmd `succeedsWith` (`shouldBe` textVal "TableCreated") | ||
| testModuleCmd `succeedsWith` (`shouldBe` textVal "test module loaded") | ||
| succeeds createAcctCmd -- Alice should be funded with $100 |
Member
There was a problem hiding this comment.
Does the comment provide any value? (I've noticed the removal here too).
| Nothing -> expectationFailure $ "Failed to find ApiResult for " ++ show _crcReqKey | ||
| Just cr -> crTest cr | ||
|
|
||
| succeeds :: HasCallStack => Command Text -> |
jwiegley
approved these changes
May 10, 2023
emilypi
approved these changes
May 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues #1220's larger changes. From #1220:
failsWith NothingandsucceedsWith Nothinghave become fails and succeedsfailsWith (Just e)andsucceedsWith (Just e)have becomefailsWith (``shouldBe`` e)andsucceedsWith (``shouldBe`` e)Just-wrapping utilities have been deletedPactErroretc.PR checklist:
cabal run tests. If they pass locally, docs are generated.pact -t), make sure pact-lsp is in sync.Additionally, please justify why you should or should not do the following: