This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Closed
Conversation
…trigger it. This helps with external repos opening PRs. They will still need approval as first-time contributors.
DevopsGoth
requested review from
emilypi,
jwiegley and
sirlensalot
as code owners
emilypi
approved these changes
Apr 13, 2023
Contributor
|
Thanks @DevopsGoth |
Contributor
|
I believe this can be safely closed, now that the PR it was related to is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the build is triggered manually or with a push. This does not allow external contributors to trigger the build. With this change, their opening of a new PR should trigger the build (though new contributors will still require approval for security reasons, to prevent malicious build modifications that do annoying things).
The creation of this PR should itself be an example.
There is more complex logic we can use to determine when a build is triggered (ie pr to a specific branch, pr is in a waiting approval state, pr has been approved, etc) but for now this should cover the use case.
Also, this PR contains the approved change from PR #1188 just to have it build (this branch was forked from that PR).