This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Conversation
jmcardon
commented
Apr 14, 2023
emilypi
approved these changes
Apr 18, 2023
Contributor
emilypi
left a comment
There was a problem hiding this comment.
looks good - feel free to make the bool change or merge
emilypi
approved these changes
Apr 18, 2023
jwiegley
reviewed
Apr 18, 2023
Contributor
jwiegley
left a comment
There was a problem hiding this comment.
A few comments. Also: have we built this into Chainweb and done a replay?
jwiegley
reviewed
Apr 19, 2023
Member
Author
|
Replay pending |
Member
Author
|
Replay is 👍 |
jwiegley
reviewed
Apr 26, 2023
jwiegley
reviewed
Apr 26, 2023
jwiegley
reviewed
Apr 26, 2023
jwiegley
approved these changes
Apr 26, 2023
jwiegley
pushed a commit
that referenced
this pull request
Apr 26, 2023
* wip fix args error * more forked errors * fix tests * fix tests * remove top level native docs on chain * Add tests for env-in-repl doc protections * forking more errors * remove bool blindness * change in-repl function name * fork native docs * env simulate on chain * Address John's comments --------- Co-authored-by: Emily Pillmore <emily@kadena.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.