Skip to content
This repository was archived by the owner on Jan 9, 2026. It is now read-only.

Forked errors on chain#1185

Merged
jmcardon merged 14 commits intomasterfrom
jose/fix-errs
Apr 26, 2023
Merged

Forked errors on chain#1185
jmcardon merged 14 commits intomasterfrom
jose/fix-errs

Conversation

@jmcardon
Copy link
Copy Markdown
Member

@jmcardon jmcardon commented Apr 6, 2023

No description provided.

@jmcardon jmcardon marked this pull request as draft April 6, 2023 15:46
@jmcardon jmcardon changed the title Forked errors on chian Forked errors on chain Apr 10, 2023
Copy link
Copy Markdown
Contributor

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - feel free to make the bool change or merge

@jmcardon jmcardon marked this pull request as ready for review April 18, 2023 16:23
Copy link
Copy Markdown
Contributor

@jwiegley jwiegley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Also: have we built this into Chainweb and done a replay?

@jmcardon
Copy link
Copy Markdown
Member Author

Replay pending

@jmcardon
Copy link
Copy Markdown
Member Author

Replay is 👍

@jmcardon jmcardon merged commit eba6fa1 into master Apr 26, 2023
jwiegley pushed a commit that referenced this pull request Apr 26, 2023
* wip fix args error

* more forked errors

* fix tests

* fix tests

* remove top level native docs on chain

* Add tests for env-in-repl doc protections

* forking more errors

* remove bool blindness

* change in-repl function name

* fork native docs

* env simulate on chain

* Address John's comments

---------

Co-authored-by: Emily Pillmore <emily@kadena.io>
@emilypi emilypi deleted the jose/fix-errs branch April 27, 2023 02:54
@emilypi emilypi mentioned this pull request May 4, 2023
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants