This repository was archived by the owner on Jan 9, 2026. It is now read-only.
Conversation
jwiegley
approved these changes
Mar 2, 2023
src-tool/Pact/Analyze/Translate.hs
Outdated
| _otherwise -> unexpectedNode astNode | ||
| case args' of | ||
| [start, stop] -> pure $ Some (SList SInteger) $ CoreTerm $ Enumerate start stop (Lit' 1) | ||
| [start, stop, step] -> pure $ Some (SList SInteger) $ CoreTerm $ Enumerate start stop step |
Contributor
There was a problem hiding this comment.
Elsewhere you say, start, end, step, consistency would make it clear there isn't any different meaning here...
Contributor
There was a problem hiding this comment.
And then other places you say from, to, step. My only suggestion is to use one set of terms throughout.
This was referenced Mar 24, 2023
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.