Skip to content
This repository was archived by the owner on Jan 9, 2026. It is now read-only.

Add support for Nix flakes#1083

Merged
jwiegley merged 6 commits intomasterfrom
johnw/nix-flake
Dec 8, 2022
Merged

Add support for Nix flakes#1083
jwiegley merged 6 commits intomasterfrom
johnw/nix-flake

Conversation

@jwiegley
Copy link
Copy Markdown
Contributor

@jwiegley jwiegley commented Dec 1, 2022

No description provided.

@jwiegley jwiegley marked this pull request as ready for review December 5, 2022 21:08
@jwiegley jwiegley requested a review from imalsogreg December 5, 2022 21:08
@imalsogreg
Copy link
Copy Markdown
Contributor

Works great!

  • nix develop . ✔️
  • nix build .# ✔️

Copy link
Copy Markdown
Contributor

@imalsogreg imalsogreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested nix develop . and nix build .#.

I was wondering if the outputs should contain some derivations beyond just the exe, which might be useful for importing pact into other projects as a flake, rather than as a Haskell source-repository-project. But let's see if we actually need that before bothering to implement it.

@jwiegley
Copy link
Copy Markdown
Contributor Author

jwiegley commented Dec 6, 2022

Oh yes, it definitely should; that'll be the next set of things we need to do, is determining which targets to make available.

@jwiegley jwiegley merged commit f5066a3 into master Dec 8, 2022
@jwiegley jwiegley deleted the johnw/nix-flake branch December 8, 2022 22:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants