This repository was archived by the owner on Nov 26, 2025. It is now read-only.
Conversation
mightybyte
reviewed
Nov 19, 2021
main/Main.hs
Outdated
| instance ToJSON Miner where | ||
| toJSON (Miner (MinerPublicKey k)) = object | ||
| [ "account" .= k | ||
| [ "account" .= ("k:" <> k) |
Contributor
There was a problem hiding this comment.
I'm not sure that we should unconditionally prepend the k:. This is pretty opaque and has some failure modes. What about allowing the user to also configure the account name? And if they don't supply one, then we can default to k:.
Contributor
Author
There was a problem hiding this comment.
Not sure, I'd like to keep it simple. I am not aware of a scenario where someone wanted to mine to anything but just a simple key.
Maybe pools have more sophisticated requirements (e.g. multi-sig accounts). But at the current state chainweb-mining-client is useful mostly for solo-miners.
Contributor
Author
There was a problem hiding this comment.
I added a --account command line option, that default to the k: account for the public key.
larskuhtz
force-pushed
the
feature/k-accounts
branch
from
e8842b8 to
1cd1485
Compare
mightybyte
approved these changes
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #16
This is a breaking change.