Lso copy move alternative map #56
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to use different map sources for copy/move operations with auto-detection of map dimensions. Introduces new UI elements including: - Checkbox to enable alternate source map - File selection for map/staidx/statics - Configuration fields for map dimensions - Automatic dimension detection based on map number - Path auto-completion for static files when selecting map Enables copying tiles between different map formats and installations.
Added detailed debug logs to LsCopyMove deserialization and ServerLandscape alternate map initialization. This helps track alternate map file loading parameters and validation during large-scale operations by logging: - UseAlternateSource flag state - Alternate file paths and dimensions - File existence checks and sizes - UOP format detection Support troubleshooting map loading issues in development environments.
- Added detailed debug logging for alternate source parameters in CopyMove.cs - Refactored LSOCopyMove serialization to use WriteStringNull for paths and cast dimensions to ushort - Improved server-side LsCopyMove deserialization with: - Try-catch block for error handling - Enhanced debug logging for each alternate source parameter - Structured reading of map dimensions as ushort values These changes improve debugging capabilities and ensure proper data serialization when using alternate map sources for copy/move operations.
When using an alternate source map: - Force Copy mode (disable Move option) with explanatory tooltip - Enforce Absolute coordinate mode (disable Relative) with tooltip - Expand source map dimension tooltips to include multiple maps - Update coordinate system switching logic to handle new constraints - Provide clear UI feedback when operations are restricted
- Update default alternate map dimensions from 768x512 to 7168x4096 in CopyMove class to support larger map sizes. - Deleted debug logs that are no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lso copy move alternative map
Add alternate map source option in copy/move tool
Add ability to use different map sources for copy/move operations with auto-detection of map dimensions. Introduces new UI elements including:
Enables copying tiles between different map formats and installations.