Skip to content

intel/disable all nmea messages #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vitus133 merged 3 commits into from
Nov 26, 2025
Merged

intel/disable all nmea messages #108

vitus133 merged 3 commits into from
Nov 26, 2025

Conversation

@lack
Copy link
Contributor

@lack lack commented Nov 23, 2025 •
edited
Loading

  • addons/intel: Abstract out ublx initialization and add unit tests
  • CNF-20497: addons/intel: Disable UBLX messages on all busses at init
  • addons/intel: Add '-w 0.1' to all ubxtool commands

@github-actions
Copy link

github-actions bot commented Nov 23, 2025

Thanks for your PR,
Best regards.

vitus133
vitus133 previously approved these changes Nov 23, 2025
View reviewed changes
Copy link
Collaborator

@vitus133 vitus133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@vitus133 vitus133 added the ok-to-test ok to test label Nov 23, 2025
lack added 3 commits November 26, 2025 07:41
@lack
addons/intel: Abstract out ublx initialization and add unit tests
7637f50 
Signed-off-by: Jim Ramsay <[email protected]>
@lack
CNF-20497: addons/intel: Disable UBLX messages on all busses at init
f033a7c 
Signed-off-by: Jim Ramsay <[email protected]>
@lack
addons/intel: Add '-w 0.1' to all ubxtool commands
fa91434 
The default wait of ubxtool is 2s, but the '-w' allows fractional input;
Waiting for 0.1s is much more responsive when all we need to do is set a
value, especially when running long strings of commands sequentially.

Signed-off-by: Jim Ramsay <[email protected]>
@lack lack force-pushed the intel/disable_all_nmea_messages branch from 4a8b6b6 to fa91434 Compare November 26, 2025 12:41
@github-actions github-actions bot removed the ok-to-test ok to test label Nov 26, 2025
@vitus133 vitus133 added the ok-to-test ok to test label Nov 26, 2025
@vitus133 vitus133 merged commit 4f3f58d into k8snetworkplumbingwg:main Nov 26, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitus133 vitus133 vitus133 approved these changes

Assignees

No one assigned

Labels

ok-to-test ok to test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lack @vitus133