Add pure-go (-nocgo) sqlite variant#678
Merged
Merged
Conversation
brandond
force-pushed
the
sqlite-nocgo
branch
9 times, most recently
from
May 29, 2026 04:58
a8f7eae to
f0fc74b
Compare
brandond
marked this pull request as ready for review
May 29, 2026 05:13
brandond
force-pushed
the
sqlite-nocgo
branch
4 times, most recently
from
May 29, 2026 07:27
c5d2867 to
50aa883
Compare
dereknola
requested changes
May 29, 2026
dereknola
left a comment
Member
There was a problem hiding this comment.
Can we duplicate the sqlite_cgo_test.go to also cover some of the pure-go sqlite implementation? Even if its a duplication of the unit test, we should have some coverage of these funtions.
dereknola
requested changes
May 29, 2026
brandond
force-pushed
the
sqlite-nocgo
branch
2 times, most recently
from
May 29, 2026 18:13
4946843 to
761fa53
Compare
dereknola
approved these changes
May 29, 2026
vitorsavian
approved these changes
May 29, 2026
brandond
force-pushed
the
sqlite-nocgo
branch
3 times, most recently
from
May 29, 2026 22:25
7fd5a94 to
29cc638
Compare
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a from-scratch rework of #557 with the unnecessary changes left out.
Other than package names, the only differences between variants are:
Linked issues:
Note: the cgo variant is actually 1mb smaller: