Skip to content

Fix nits in memory driver#661

Merged
brandond merged 1 commit into
k3s-io:masterfrom
brandond:memory-nits
May 7, 2026
Merged

Fix nits in memory driver#661
brandond merged 1 commit into
k3s-io:masterfrom
brandond:memory-nits

Conversation

@brandond

@brandond brandond commented May 6, 2026

Copy link
Copy Markdown
Member
  1. We don't need compact_rev_key, thats only used for SQL; the memory driver has m.compactRevision
  2. Move broadcast() into appendEntry() since its always called after it
  3. Simplify log trimming in Compact, and ensure that compact always leaves one revision in the log for consistency with etcd and sql-based backends.
  4. Move a couple strings into constants, since they are common to all drivers
  5. Don't allow compacting future or already-compacted revisions, for consistency with etcd

@brandond
brandond requested a review from a team as a code owner May 6, 2026 22:02
@brandond
brandond force-pushed the memory-nits branch 3 times, most recently from 09b0f95 to 9afb01c Compare May 7, 2026 00:08
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond
brandond merged commit ec067b2 into k3s-io:master May 7, 2026
47 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants