[release-1.34] Move data dir into position before creating CNI symlinks#12876
Merged
brandond merged 1 commit intoSep 8, 2025
Merged
Conversation
Addresses issue where CNI bin symlinks were created with targets that were not yet valid, which caused external container runtimes that rely on filesystem notifications to detect changes to think that the bins did not exist. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## release-1.34 #12876 +/- ##
=================================================
- Coverage 40.62% 20.47% -20.16%
=================================================
Files 185 182 -3
Lines 18937 18869 -68
=================================================
- Hits 7694 3863 -3831
- Misses 10063 14570 +4507
+ Partials 1180 436 -744
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dereknola
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Move data dir into position before creating CNI symlinks
Addresses issue where CNI bin symlinks were created with targets that were not yet valid, which caused external container runtimes that rely on filesystem notifications to detect changes to think that the bins did not exist.
Types of Changes
Bugfix
Verification
See linked issue - user will probably need to validate as this is a fairly odd configuration.
Testing
Linked Issues
User-Facing Change
Further Comments