Skip to content

Fix PID tracking for Nightly Conformance#12714

Merged
dereknola merged 1 commit into
k3s-io:masterfrom
dereknola:cnf_parrallel
Aug 6, 2025
Merged

Fix PID tracking for Nightly Conformance#12714
dereknola merged 1 commit into
k3s-io:masterfrom
dereknola:cnf_parrallel

Conversation

@dereknola

@dereknola dereknola commented Aug 5, 2025

Copy link
Copy Markdown
Member

Signed-off-by: Derek Nola derek.nola@suse.com

Proposed Changes

Fix nightly conformance to not overload the node and cause errors. PIDs where not being propagated due to use of exec subshell.

Types of Changes

CI Fix

Verification

Actually see the number of tests count increasing:

[test:3169] Currently running 4 tests

Compared to currently:
https://drone-publish.k3s.io/k3s-io/k3s/4708/1/3

[PARALLEL SQLITE] go: downloading github.com/urfave/cli/v2 v2.27.7
Currently running 0 tests

Testing

Can't test via CI, have to wait for nightly

Linked Issues

N/A

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola dereknola changed the title Temp_Run _All Fix PID tracking for Nightly Conformance Aug 5, 2025
@dereknola
dereknola marked this pull request as ready for review August 5, 2025 17:48
@dereknola
dereknola requested a review from a team as a code owner August 5, 2025 17:48
@codecov

codecov Bot commented Aug 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 20.49%. Comparing base (3bae735) to head (2d27dd1).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (3bae735) and HEAD (2d27dd1). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3bae735) HEAD (2d27dd1)
e2etests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12714       +/-   ##
===========================================
- Coverage   40.72%   20.49%   -20.24%     
===========================================
  Files         184      181        -3     
  Lines       18869    18801       -68     
===========================================
- Hits         7685     3853     -3832     
- Misses      10004    14512     +4508     
+ Partials     1180      436      -744     
Flag Coverage Δ
e2etests ?
unittests 20.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dereknola
dereknola merged commit ff6abe8 into k3s-io:master Aug 6, 2025
40 checks passed
@dereknola
dereknola deleted the cnf_parrallel branch October 15, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants