Skip to content

Add retry around common timeout for hardened docker test#12601

Merged
dereknola merged 1 commit into
k3s-io:masterfrom
dereknola:hardened_flaky
Jul 11, 2025
Merged

Add retry around common timeout for hardened docker test#12601
dereknola merged 1 commit into
k3s-io:masterfrom
dereknola:hardened_flaky

Conversation

@dereknola

@dereknola dereknola commented Jul 10, 2025

Copy link
Copy Markdown
Member

Signed-off-by: Derek Nola derek.nola@suse.com

Proposed Changes

  • Fixed most common error seen around hardnened docker test failures. Now we retry when checking ingress connections, in the case where the netpool.yaml policies are not yet fully in effect.

Types of Changes

CI Fix

Verification

CI is more green

Testing

Linked Issues

User-Facing Change


Further Comments

Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
dereknola requested a review from a team as a code owner July 10, 2025 17:31
@codecov

codecov Bot commented Jul 10, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.98%. Comparing base (7ab7865) to head (8bcc079).
Report is 5 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (7ab7865) and HEAD (8bcc079). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (7ab7865) HEAD (8bcc079)
e2etests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12601       +/-   ##
===========================================
- Coverage   40.43%   19.98%   -20.46%     
===========================================
  Files         186      183        -3     
  Lines       19333    19241       -92     
===========================================
- Hits         7818     3845     -3973     
- Misses      10316    14962     +4646     
+ Partials     1199      434      -765     
Flag Coverage Δ
e2etests ?
unittests 19.98% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dereknola
dereknola merged commit 3b06d9d into k3s-io:master Jul 11, 2025
40 checks passed
dereknola added a commit to dereknola/k3s that referenced this pull request Jul 11, 2025
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Jul 11, 2025
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Jul 11, 2025
Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit to dereknola/k3s that referenced this pull request Jul 11, 2025
Signed-off-by: Derek Nola <derek.nola@suse.com>
@dereknola
dereknola deleted the hardened_flaky branch July 11, 2025 17:08
dereknola added a commit that referenced this pull request Jul 11, 2025
* Move to more secure split trivy workflow based on labels, not comments (#12592)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Add basic fuzz test

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Add retry around common timeout for hardened docker test (#12601)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Remove ghcr build cache (#12602)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Migrate K3s Release Artifacts to GHA (#12606)

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Jul 11, 2025
* Move to more secure split trivy workflow based on labels, not comments (#12592)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Add basic fuzz test

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Add retry around common timeout for hardened docker test (#12601)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Remove ghcr build cache (#12602)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Migrate K3s Release Artifacts to GHA (#12606)

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Jul 11, 2025
* Move to more secure split trivy workflow based on labels, not comments (#12592)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Add basic fuzz test

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Add retry around common timeout for hardened docker test (#12601)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Remove ghcr build cache (#12602)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Migrate K3s Release Artifacts to GHA (#12606)

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
dereknola added a commit that referenced this pull request Jul 11, 2025
* Move to more secure split trivy workflow based on labels, not comments (#12592)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Add basic fuzz test

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Add retry around common timeout for hardened docker test (#12601)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Remove ghcr build cache (#12602)

Signed-off-by: Derek Nola <derek.nola@suse.com>

* Migrate K3s Release Artifacts to GHA (#12606)

Signed-off-by: Derek Nola <derek.nola@suse.com>

---------

Signed-off-by: Derek Nola <derek.nola@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants