Skip to content

Remove references to master node-role label and taints/tolerations#12395

Merged
dereknola merged 1 commit into
k3s-io:masterfrom
yulken:feature/remove-master-role-labels
May 28, 2025
Merged

Remove references to master node-role label and taints/tolerations#12395
dereknola merged 1 commit into
k3s-io:masterfrom
yulken:feature/remove-master-role-labels

Conversation

@yulken

@yulken yulken commented May 26, 2025

Copy link
Copy Markdown
Contributor

Proposed Changes

Removing references to 'master' node label.

Types of Changes

New feature

Verification

Execute kubectl get nodes on the server designated as control-plane.

Testing

Yes

Linked Issues

User-Facing Change


Further Comments

@yulken
yulken requested a review from a team as a code owner May 26, 2025 19:23
@codecov

codecov Bot commented May 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 19.91%. Comparing base (8d8d1f4) to head (a93eb14).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (8d8d1f4) and HEAD (a93eb14). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8d8d1f4) HEAD (a93eb14)
e2etests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12395       +/-   ##
===========================================
- Coverage   40.53%   19.91%   -20.63%     
===========================================
  Files         187      184        -3     
  Lines       19291    19220       -71     
===========================================
- Hits         7820     3828     -3992     
- Misses      10276    14961     +4685     
+ Partials     1195      431      -764     
Flag Coverage Δ
e2etests ?
unittests 19.91% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Caio Torres <caio.torres@suse.com>
@yulken yulken changed the title feat: remove master role labels Remove references to master node-role label and taints/tolerations May 27, 2025
@dereknola
dereknola merged commit 7294033 into k3s-io:master May 28, 2025
@yulken
yulken deleted the feature/remove-master-role-labels branch May 28, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants