Remove references to master node-role label and taints/tolerations#12395
Merged
dereknola merged 1 commit intoMay 28, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12395 +/- ##
===========================================
- Coverage 40.53% 19.91% -20.63%
===========================================
Files 187 184 -3
Lines 19291 19220 -71
===========================================
- Hits 7820 3828 -3992
- Misses 10276 14961 +4685
+ Partials 1195 431 -764
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Caio Torres <caio.torres@suse.com>
dereknola
approved these changes
May 27, 2025
vitorsavian
approved these changes
May 27, 2025
brandond
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Removing references to 'master' node label.
Types of Changes
New feature
Verification
Execute
kubectl get nodeson the server designated as control-plane.Testing
Yes
Linked Issues
masternode-role label and taints/tolerations #11117User-Facing Change
Further Comments