Fix secretsencrypt race conditions#12351
Merged
Merged
Conversation
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Ensure startup hooks WaitGroup is initialized before starting goroutine that will wait on it Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12351 +/- ##
===========================================
- Coverage 41.07% 19.89% -21.18%
===========================================
Files 166 184 +18
Lines 19000 19221 +221
===========================================
- Hits 7804 3824 -3980
- Misses 10003 14966 +4963
+ Partials 1193 431 -762
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vitorsavian
approved these changes
May 15, 2025
cwayne18
approved these changes
May 15, 2025
This was referenced May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix multiple race conditions in k3s startup that could cause handled and unhandled panics
Types of Changes
bugfix
Verification
See linked issues
Testing
todo: #11647
Linked Issues
secrets-encryptprepare on split etcd/controlplane setup rancher/rke2#8236User-Facing Change
Further Comments