Skip to content

Fix secretsencrypt race conditions#12351

Merged
brandond merged 2 commits into
k3s-io:masterfrom
brandond:fix-secretsencrypt-panic
May 15, 2025
Merged

Fix secretsencrypt race conditions#12351
brandond merged 2 commits into
k3s-io:masterfrom
brandond:fix-secretsencrypt-panic

Conversation

@brandond

@brandond brandond commented May 15, 2025

Copy link
Copy Markdown
Member

Proposed Changes

Fix multiple race conditions in k3s startup that could cause handled and unhandled panics

Types of Changes

bugfix

Verification

See linked issues

Testing

todo: #11647

Linked Issues

User-Facing Change

Further Comments

brandond added 2 commits May 15, 2025 19:41
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Ensure startup hooks WaitGroup is initialized before starting goroutine that will wait on it

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond
brandond requested a review from a team as a code owner May 15, 2025 20:12
@codecov

codecov Bot commented May 15, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 19.89%. Comparing base (effe6ce) to head (cb68f5b).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/server/handlers/secrets-encrypt.go 0.00% 4 Missing ⚠️
pkg/cli/server/server.go 0.00% 3 Missing ⚠️
pkg/server/server.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (effe6ce) and HEAD (cb68f5b). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (effe6ce) HEAD (cb68f5b)
e2etests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12351       +/-   ##
===========================================
- Coverage   41.07%   19.89%   -21.18%     
===========================================
  Files         166      184       +18     
  Lines       19000    19221      +221     
===========================================
- Hits         7804     3824     -3980     
- Misses      10003    14966     +4963     
+ Partials     1193      431      -762     
Flag Coverage Δ
e2etests ?
unittests 19.89% <0.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants