Skip to content

Fix authorization-config/authentication-config handling#12338

Merged
brandond merged 1 commit into
k3s-io:masterfrom
brandond:fix-anonymous
May 15, 2025
Merged

Fix authorization-config/authentication-config handling#12338
brandond merged 1 commit into
k3s-io:masterfrom
brandond:fix-anonymous

Conversation

@brandond

@brandond brandond commented May 14, 2025

Copy link
Copy Markdown
Member

Proposed Changes

  • Fix authorization-config/authentication-config handling.
    Need to handle authn/authz config separately. Also, the warning was being printed under the wrong condition.

Types of Changes

Bugfix

Verification

See linked issue

Testing

Yes

Linked Issues

User-Facing Change

Further Comments

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond
brandond requested a review from a team as a code owner May 14, 2025 18:45
@codecov

codecov Bot commented May 14, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 19.91%. Comparing base (effe6ce) to head (508e1ff).

Files with missing lines Patch % Lines
pkg/server/handlers/secrets-encrypt.go 0.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (effe6ce) and HEAD (508e1ff). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (effe6ce) HEAD (508e1ff)
e2etests 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12338       +/-   ##
===========================================
- Coverage   41.07%   19.91%   -21.17%     
===========================================
  Files         166      184       +18     
  Lines       19000    19228      +228     
===========================================
- Hits         7804     3829     -3975     
- Misses      10003    14968     +4965     
+ Partials     1193      431      -762     
Flag Coverage Δ
e2etests ?
unittests 19.91% <63.63%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

vitorsavian
vitorsavian previously approved these changes May 14, 2025
fmoral2
fmoral2 previously approved these changes May 14, 2025
@brandond
brandond dismissed stale reviews from fmoral2 and vitorsavian via 1d14f0a May 14, 2025 22:12
@brandond
brandond force-pushed the fix-anonymous branch 5 times, most recently from 508e1ff to 235b999 Compare May 15, 2025 18:28
@brandond
brandond requested review from fmoral2 and vitorsavian May 15, 2025 19:36
@brandond
brandond requested a review from a team May 15, 2025 19:38
@brandond
brandond merged commit cb889d4 into k3s-io:master May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants