Implement certificate check with file-oriented view and usage types#12226
Conversation
4cf059f to
7eda2c0
Compare
The output is file-oriented. Each file contains both an end entity certificate (either a client/server cert or an intermediate cert) as well as the chain back to the root CA certificate. The root and intermediate CA certs expire, just as the EE certs do; it is possible for the copy of the root or intermediates to be different in different files, so the check output shows a full list of each certificate found in each file. Reorganizing the output to group by certificate subject instead of simply listing each certificate in each file would not be something we want to do. |
86324e1 to
0a9183e
Compare
|
😁 Hi @brandond, Based on the discussion, I've implemented a file-oriented certificate check with:
Sample output: Does this meet expectations? 🤝 |
0a9183e to
b482bd2
Compare
|
Thanks, that looks good to me! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12226 +/- ##
===========================================
- Coverage 40.39% 19.78% -20.62%
===========================================
Files 187 184 -3
Lines 19211 19196 -15
===========================================
- Hits 7760 3797 -3963
- Misses 10268 14969 +4701
+ Partials 1183 430 -753
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
953e27f to
8ae98b6
Compare
8ae98b6 to
7faac70
Compare
51bd49d to
705f1ee
Compare
fd80999 to
e100b5a
Compare
Signed-off-by: bo.jiang <bo.jiang@daocloud.io>
e100b5a to
b70d7d7
Compare
Proposed Changes
This PR implements a certificate check feature that:
USAGESfield to distinguish betweenCertSign/ServerAuth/ClientAuthCERTIFICATEcolumn toFILENAMEfor clarityTypes of Changes
New Feature
Verification
Testing
Linked Issues
#12049
User-Facing Change
Further Comments