-
Notifications
You must be signed in to change notification settings - Fork 94
Adding securityContext #216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jiri Tyr <[email protected]>
brandond
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits/questions
Signed-off-by: Jiri Tyr <[email protected]>
jtyr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review. All issues should be fixed now.
Signed-off-by: Jiri Tyr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also call out more specifically the other changes in the PR description? Namely, that in addition to making the SecurityContexts configurable, it also hardens the default values by:
- Enabling ReadOnlyRootFilesystem
- Enabling RunAsNonRoot
- Dropping all capabilities
- Adding tmpfs mounts for
/home/klipper-helm/.(helm|cache|config)
|
Looks like one of the tests is failing: |
2dd636f to
f60e171
Compare
Signed-off-by: Jiri Tyr <[email protected]>
This PR is adding
securityContextto make the Jobs created by this controller more secure. The defaultsecurityContextis set to comply with theRestrictedPod Security Standard profile but it can be further tweaked via thepodSecurityContextand thesecurityContextfields of theHelmChartCustom Resource. Jobs created by the controller are further hardened by enablingreadOnlyRootFilesystemand enabling write access only totmpfsmounts/home/klipper-helm/.(helm|cache|config).