fix: forward step headers to reflection RPC#1485
Merged
Merged
Conversation
step-level `headers:` are now passed to the reflection client context, so reflection succeeds against servers that require auth on every RPC (including the reflection RPC itself). Previously `connectAndResolve` received a bare `ctx`, causing UNAUTHENTICATED failures when the server's auth interceptor covered reflection. The fix threads `setHeaders(ctx, r.headers)` into `connectAndResolve`, mirroring grpcurl's `-H` behaviour. Closes k1LoW#1484 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
@kimoto Good catch!! Thank you for your contribution!! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
headers:were not forwarded to the reflection client context, so runn failed withUNAUTHENTICATEDagainst servers whose auth interceptor covers every RPC including reflectionsetHeaders(ctx, r.headers)toconnectAndResolveinrun(), mirroring the behaviour ofgrpcurl -HFixes #1484
Test plan
TestGrpcRunnerReflectionWithAuth/step headers are forwarded to reflection RPC— verifies the fix works against an auth-required serverTestGrpcRunnerReflectionWithAuth/reflection RPC fails without step headers— documents that the server correctly rejects unauthenticated callsTest results
Before fix (FAIL):
After fix (PASS):