Conversation
|
Thanks for this contribution! Since this is not relevant to most users, I do not want to crowed the main README. Could you please move the instructions to the docs and maybe just add a single line on the main README that links to it? |
That's a great idea, I have moved the information to the docs. |
|
Thanks a bunch, great PR!! |
My pleasure. Now I just realized it would have been a good idea to bump the patch to Thanks for the openness and happy to contribute. |
|
@jwohlwend should I bump the minor version of the open source to patch to |
|
this was merged and released with 2.2.0! |
Adding MSA server security
Summary
This PR adds security/authentication support for calling custom MSA servers in Boltz, enabling the use of both basic authentication and API token authentication when accessing protected MSA endpoints.
Changes
MSA Server Authentication Support:
--msa_server_usernameand--msa_server_passwordCLI options, or via theBOLTZ_MSA_USERNAMEandBOLTZ_MSA_PASSWORDenvironment variables.--api_key_headerand--api_key_valueCLI options, or via theMSA_API_KEY_VALUEenvironment variable.Documentation:
Motivation
Many custom MSA servers require authentication for access. This PR enables Boltz users to securely provide credentials—either via basic auth or API token—when calling such servers, making Boltz compatible with a wider range of enterprise and protected deployments. Additionally if no authentication is required, everything works as before so it is simply optional.
See the "Authentication to MSA Server" section in the README for details and usage examples.
These changes make it easier for users to securely provide credentials for MSA server access, reduce confusion around environment variable names, and ensure the documentation matches the actual code behavior.
See the "Authentication to MSA Server" section in the README for details and usage examples.
s