-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Description
First, pillow is required to run the test suite and doesn't seem to be mentioned as a test dependency anywhere. I must be blind, it's right there in requirements-dev.txt.
Second it seems numpy should be listed as a test dependency, not as a regular dependency. It is used directly for tests. I looked through the skip-python code based and it seems the same there, it is never used directly in the library but it is used for the test suite. As such they seem to have it specified properly and the only improper thing is where this shows up and moving it to test deps would be appropriate:
Line 26 in f9d5314
| "numpy", # unlisted skia-python dependency, TODO: is this true? |
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels