Skip to content

Dependency issues #33

@alerque

Description

@alerque

First, pillow is required to run the test suite and doesn't seem to be mentioned as a test dependency anywhere. I must be blind, it's right there in requirements-dev.txt.

Second it seems numpy should be listed as a test dependency, not as a regular dependency. It is used directly for tests. I looked through the skip-python code based and it seems the same there, it is never used directly in the library but it is used for the test suite. As such they seem to have it specified properly and the only improper thing is where this shows up and moving it to test deps would be appropriate:

"numpy", # unlisted skia-python dependency, TODO: is this true?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions