correct the misspelled three and add file(link) support#6
Merged
justoverclockl merged 5 commits intojustoverclockl:mainfrom Jan 25, 2024
Merged
correct the misspelled three and add file(link) support#6justoverclockl merged 5 commits intojustoverclockl:mainfrom
justoverclockl merged 5 commits intojustoverclockl:mainfrom
Conversation
Owner
|
thx @WhXcjm can you please remove all comments? and can you explain why we need file support? i think that unoptimized images can becomes too heavy?, anywai i will test this when comments are removed ;) |
Contributor
Author
Owner
|
@WhXcjm ok but image should be into the assets folder, not all users are are developer, so we should simplify this, maybe with an URL?, at moment, if i put an url i can't see any image https://cdnjs.cloudflare.com/ajax/libs/twemoji/15.0.3/72x72/1f970.png |
Owner
|
oh i see it now, i need to put link: before....ok |
justoverclockl
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Dear Maintainers,
In this Pull Request, I have addressed two key issues:
Spelling Mistake Correction:
I have identified and corrected multiple instances in the code where "three" was mistakenly spelled as "tree". This error was causing modifications related to Level Three to be ineffective in the Administration. I have checked and corrected all such occurrences to ensure the accuracy and integrity of the level system.
Adding Support for Online Image Links:
Additionally, I have implemented support for online image links, such as using 'file:/assets/custombadges/level_1.png'. This allows users to use custom icons beyond what is available in font awesome, enhancing personalization and flexibility. This change will make our project more user-friendly and offer more customization options.
I believe these changes will significantly improve the functionality and user experience of this project.
Looking forward to your feedback and hoping for the swift integration of these changes.
Best regards,
WhXcjm