-
-
Notifications
You must be signed in to change notification settings - Fork 117
Feat(rnpsw) add commit title check #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat(rnpsw) add commit title check #226
Conversation
|
@Jokotoye18 thanks a mill for working on this. This will ensure folks don't open PRs without the desired commit titles and stop a lot of deployment and release issues moving forward! I will review this right away! @Jokotoye18 Domt forget to remove from draft. |
This is now ready for review @just1and0 |
|
@Jokotoye18 please can you update the pr description. |
| ] | ||
| } | ||
| ], | ||
| "packageManager": "[email protected]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jokotoye18 Remember we’re also bumping this to [email protected] in your other PR…hope that won’t cause any conflicts?
Description
Currently when contributors raise PRs, they usually forget to use the correct commit title convension and this breaks CI, and features don't get published to npm.
We need to add a pre check when users try to make a commit. And show meaningful warnings⚠️
Issue URL
#206
Before and After
Add Image/video/gifs of changes