build: obtain workspace member package names from cargo_metadata more deterministically #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… deterministically
Chethan-rao
requested review from
Narayanbhat166,
NishantJoshi00 and
SanchithHegde
SanchithHegde
approved these changes
Mar 20, 2024
Narayanbhat166
approved these changes
Mar 21, 2024
NishantJoshi00
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the build script code to obtain cargo workspace member package names to use a better and more deterministic way to do so.
Previously, we used to perform string manipulation on the package ID format (obtained from the
workspace_membersfield incargo metadata --format-version=1), and the package ID format was not stabilized (until recently). The package ID format has been stabilized in Rust 1.77, and the stabilized format breaks our existing build scripts. This PR updates the build script code to instead obtain the workspace member package names using theMetadata::workspace_packages()method that thecargo_metadatacrate provides.