Cleanup how mounts are handled #535
Merged
+14
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuvipanda
commented
Apr 4, 2025
yuvipanda
commented
- Don't require specific keys (like 'source') to be present, as there are mount types that don't need that (like https://docs.docker.com/engine/storage/tmpfs/)
- Format all values, not just source and destination.
- Remove two layers of indirection - mount_binds was only used in one place, so let's just use it there.
- Don't require specific keys (like 'source') to be present, as there are mount types that don't need that (like https://docs.docker.com/engine/storage/tmpfs/) - Format all values, not just source and destination. - Remove two layers of indirection - mount_binds was only used in one place, so let's just use it there.
yuvipanda
force-pushed
the
cleaner-mounts
branch
from
5f5e556 to
c303efe
Compare
yuvipanda
force-pushed
the
cleaner-mounts
branch
from
fdfb30b to
53de932
Compare
yuvipanda
force-pushed
the
cleaner-mounts
branch
from
f991958 to
1f73a9f
Compare
yuvipanda
force-pushed
the
cleaner-mounts
branch
3 times, most recently
from
a693d94 to
3c621f8
Compare
for more information, see https://pre-commit.ci
minrk
approved these changes
Apr 11, 2025
Member
minrk
left a comment
minrk
left a comment
There was a problem hiding this comment.
LGTM! Is there an easy test to add for this? I don't think mounts get exercised at all, yet. If it's not simple, no worries, we can add an Issue for test coverage of mounts and still merge this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.