Skip to content

Conversation

@romainx
Copy link
Collaborator

@romainx romainx commented Mar 17, 2020

Hello,

Try the latest Miniconda / conda version 4.8.2. I've only tested base-notebook 😨 ...
I've noticed that, since this version, Miniconda is provided in two Python versions

  • Miniconda3-py37_4.8.2-Linux-x86_64.sh
  • Miniconda3-py38_4.8.2-Linux-x86_64.sh

I've kept Python 3.7.x, one change at a time 😌.

Please note that I've not used an ARG or an ENV to switch between the two Python versions (py37 / py38). We have already conda and Python versions in the file.

Perfect is the enemy of good.

But I can dot it, if someone think it's better.

Best.

@romainx romainx requested a review from parente March 17, 2020 19:28
Copy link
Member

@parente parente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it! 🎉

wget --quiet https://repo.continuum.io/miniconda/Miniconda3-py37_${MINICONDA_VERSION}-Linux-x86_64.sh && \
echo "${MINICONDA_MD5} *Miniconda3-py37_${MINICONDA_VERSION}-Linux-x86_64.sh" | md5sum -c - && \
/bin/bash Miniconda3-py37_${MINICONDA_VERSION}-Linux-x86_64.sh -f -b -p $CONDA_DIR && \
rm Miniconda3-py37_${MINICONDA_VERSION}-Linux-x86_64.sh && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to hardcode 3.7 for now. I've not looked into whether all of the packages we include are compatible and built for 3.8 in conda-forge yet.

@parente parente merged commit dc97447 into jupyter:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants