feat: adds option to pass a getProcessCommandLine function#125
Open
jlcarvalho wants to merge 2 commits intojunlarsen:masterfrom
Open
feat: adds option to pass a getProcessCommandLine function#125jlcarvalho wants to merge 2 commits intojunlarsen:masterfrom
jlcarvalho wants to merge 2 commits intojunlarsen:masterfrom
Conversation
jlcarvalho
force-pushed
the
master
branch
3 times, most recently
from
9412389 to
2ba1ee3
Compare
jlcarvalho
changed the title
jlcarvalho
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases it may be necessary to use a custom function to retrieve League's command line string, since the current methods (
Get-CimInstanceandwmic) rely on WMI, which may be unavailable (or broken) on some Windows machines.This PR implements @junlarsen's suggestion from the discussion in #124.