replaced use of Arrays.copyOf for Java 1.5 compatibility

[adam-beneschan]

No description provided.

[kcooney]

Java 5 reached end of life on October, 2009, and Java 6 reached EOL in February, 2013:
http://www.oracle.com/technetwork/java/eol-135779.html
http://slashdot.org/story/13/06/20/1819245/java-6-eold-by-oracle

I think we should ask on the community if there is any reason why JUnit should continue to support Java 5.

[dsaff]

@kcooney,

A reasonable point. I think this change should go in, and we should prepare a 4.12 release that compiles under Java 5; that way, people who are stuck on Java 5 for whatever reason can stick to 4.12, if we decide to drop Java 5 support going forward.

[dsaff]

Thanks, @adam-beneschan !

[kcooney]

@dsaff I understand, though, still disagree :-)

But either way, before copying our own implementation of Arrays.copyOf() couldn't we have modified the code to use a List?

[adam-beneschan]

@kcooney Since things were already working and tested as an array, it made the most sense to me to keep it that way; by replacing the Arrays.copyOf() call with something equivalent, so that nothing else needed to change. I don't see any gain in using a List in this case, since the array is returned by one private method and used by another private method and then disappears. If getThreadArray were a general utility public method, perhaps it would be better if it returned a List, but then we'd also want to move it out of the FailOnTimeout class. Maybe that's a refactoring that could be done at some point.