-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[bash,zsh] Fix the version check for mawk #4574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@LangLangBart @LimingFang Could you check the behavior of this patch? |
tested with debian 10, the error no longer shows up.
can u share the output from I believe you need to either compile the fzf binary or source the patched file |
|
Output of I just remove my fzf repo and use branch in @akinomyoga 's repo and |
Unfortunately, |
My bad, everything works fine now. cc @LangLangBart |
We have been checking the mawk version by extracting <x>, <y>, <z>, and <d> part from "mawk <x>.<y>.<z> <d>" in the output of the "mawk -W version" and testing <x>, <y>, <z>, and <d> using an arithmetic evalaution. However, <d> is ensured to be an integer only in "x.y.z >= 1.3.4". Otherwise, it may cause a syntax error in the arithmetic evaluation. The mawk started to include the date as an integer in the <d> position only from mawk-1.3.3-20090721. We should first check that "x.y.z >= 1.3.4" and then check the value of "d". In case, "mawk -W version" produces a completely different text, we should also redirect stderr of the arithmetic commands to /dev/null.
222c009 to
7aec010
Compare
|
Thanks! |
|
Thanks! |
|
Thank you! |

This fixes #4570. See the commit message for details.