use StridedMaybeAdjOrTransMat instead of defining it#217
Merged
blegat merged 1 commit intojump-dev:masterfrom May 2, 2023
dkarrasch:master
Merged
use StridedMaybeAdjOrTransMat instead of defining it#217blegat merged 1 commit intojump-dev:masterfrom dkarrasch:master
StridedMaybeAdjOrTransMat instead of defining it#217blegat merged 1 commit intojump-dev:masterfrom
dkarrasch:master
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #217 +/- ##
==========================================
+ Coverage 86.73% 89.04% +2.30%
==========================================
Files 22 23 +1
Lines 1923 2136 +213
==========================================
+ Hits 1668 1902 +234
+ Misses 255 234 -21
☔ View full report in Codecov by Sentry. |
Member
|
Thanks! It's indeed helpful for MutableArithmetics to try to reduce the number of methods in stdlib as done in JuliaLang/julia#49521 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This move avoids conflicts that may occur with slightly changing the use of the type parameter in JuliaLang/julia#49521. It is necessary because in that linalg file, the
Blas*restriction is usually used in the place of the eltype of theStridedArray, and not as the eltype of theAdjointorTranspose. Moving the definition here into the VERSION branch neatly adopts that change and makes the package run smoothly across v1.6 - v1.10.