fuse: add inode cache invalidation on file open #6326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add InodeNotify call in Open method to force kernel cache invalidation when files are opened. This ensures that clients get fresh inode attribute information instead of relying on potentially stale cached data. The change calls fsserv.InodeNotify() with the opened file's inode ID to notify the kernel to invalidate its cached attribute information. This improves consistency across multiple clients accessing the same files. Resolves: juicedata#6323
|
|
Contributor
|
Be careful to not introduce a deadlock when calling |
Contributor
Author
1. FrequencyInodeNotify is invoked at most once per file—right when it is opened. 2. SafetyIt never endangers the JuiceFS daemon:
3. Deadlock Risk
|
davies
reviewed
Aug 29, 2025
pkg/fuse/fuse.go
Outdated
| } else if entry.Attr.KeepCache { | ||
| out.OpenFlags |= fuse.FOPEN_KEEP_CACHE | ||
| } | ||
| fsserv.InodeNotify(uint64(in.NodeId), -1, 0) |
Contributor
There was a problem hiding this comment.
The OpenFlags is used to tell kernel to invalidate data cache.
The returned attribute of Open should overwrite stale attr in kernel, so InodeNotify is not needed, I think.
Contributor
Author
There was a problem hiding this comment.
As far as I know, certain OpenFlags can affect how the kernel handles file caching, but there is no specific flag dedicated to 'invalidating the cache'.
Contributor
There was a problem hiding this comment.
maybe change to this, only invalidate cache when mtime changed. @yangliping
else if entry.Attr.KeepCache {
out.OpenFlags |= fuse.FOPEN_KEEP_CACHE
} else {
fsserv.InodeNotify(uint64(in.NodeId), -1, 0)
}
Move the fsserv.InodeNotifycall inside the else branch to prevent unnecessary notifications.
jiefenghuang
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add InodeNotify call in Open method to force kernel cache invalidation when files are opened. This ensures that clients get fresh inode attribute information instead of relying on potentially stale cached data.
The change calls fsserv.InodeNotify() with the opened file's inode ID to notify the kernel to invalidate its cached attribute information. This improves consistency across multiple clients accessing the same files.
Resolves: #6323