cmd/gc: scan leaked inodes and edges #5795
Conversation
Signed-off-by: jiefenghuang <[email protected]>
Signed-off-by: jiefenghuang <[email protected]>
| }, 0); err != nil { | ||
| logger.Errorf("delete leaked edges: %s", err) | ||
| return | ||
| } |
There was a problem hiding this comment.
It's possible that a file becomes dangling when it has node and edge, but parent node not exists.
There was a problem hiding this comment.
The primary purpose is to provide a scanning tool along with a detail for repair; as for deletion, the entire subtree can be removed through multiple iterations.
| cutoff := time.Now().Add(-before) | ||
|
|
||
| nodes := make(map[Ino]*Attr) | ||
| if err := m.client.scan(nil, func(key, value []byte) { |
There was a problem hiding this comment.
The scan may take pretty long, leaving the nodes and edges inconsistent.
There was a problem hiding this comment.
kv scan occur within the same snapshot; however, Redis cannot guarantee this consistency. Therefore, it’s advisable to perform a double-check at the end.
There was a problem hiding this comment.
this will indeed be time-consuming
will add a configuration that disabled by default.
Signed-off-by: jiefenghuang <[email protected]>
| for inode, attr := range nodes { | ||
| if _, ok := foundInodes[inode]; !ok && time.Unix(attr.Ctime, 0).Before(cutoff) { | ||
| if _, ok := node2Edges[inode]; !ok && time.Unix(attr.Ctime, 0).Before(cutoff) { | ||
| logger.Infof("found leaded inode: %d %+v", inode, attr) |
There was a problem hiding this comment.
Need double check according to the attr.Parent or parent key as well. See baseMeta.GetPaths
|
|
||
| var edges []edge | ||
| var nodes []node | ||
| if err := m.txn(func(s *xorm.Session) error { |
close #5420
ref #1097