Skip to content

Conversation

@SandyXSD
Copy link
Contributor

@SandyXSD SandyXSD commented Apr 24, 2022

close #1874

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

Merging #1879 (a1042ee) into main (85af540) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1879      +/-   ##
==========================================
+ Coverage   61.28%   61.38%   +0.09%     
==========================================
  Files         135      135              
  Lines       23410    23414       +4     
==========================================
+ Hits        14347    14372      +25     
+ Misses       7389     7373      -16     
+ Partials     1674     1669       -5     
Impacted Files Coverage Δ
pkg/meta/interface.go 56.19% <100.00%> (+0.36%) ⬆️
pkg/meta/sql.go 64.63% <0.00%> (+0.09%) ⬆️
pkg/vfs/writer.go 79.66% <0.00%> (+1.01%) ⬆️
pkg/vfs/reader.go 80.29% <0.00%> (+3.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85af540...a1042ee. Read the comment docs.

@SandyXSD SandyXSD requested review from davies and zhijian-pro and removed request for zhijian-pro April 24, 2022 07:40
@SandyXSD SandyXSD changed the title meta: escape user info in the meta uri meta: escape meta password from env Apr 24, 2022
Copy link
Contributor

@zhijian-pro zhijian-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pg test passed

@SandyXSD SandyXSD merged commit bef72c0 into main Apr 24, 2022
@SandyXSD SandyXSD deleted the escape-meta-uri branch April 24, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't use meta password containing '|'

5 participants