meta: specify the format field preventing update

pkg/meta/config.go

@@ -63,6 +63,37 @@ type Format struct {
 	MaxClientVersion string
 }
 
+func (f *Format) update(old *Format, force bool) error {
+	if force {
+		old.RemoveSecret()
+		logger.Warnf("Existing volume will be overwrited: %+v", *old)
+	} else {
+		var args []interface{}
+		switch {
+		case f.Name != old.Name:
+			args = []interface{}{"name", old.Name, f.Name}
+		case f.Storage != old.Storage:
+			args = []interface{}{"storage", old.Storage, f.Storage}
+		case f.BlockSize != old.BlockSize:
+			args = []interface{}{"block size", old.BlockSize, f.BlockSize}
+		case f.Compression != old.Compression:
+			args = []interface{}{"compression", old.Compression, f.Compression}
+		case f.Shards != old.Shards:
+			args = []interface{}{"shards", old.Shards, f.Shards}
+		case f.HashPrefix != old.HashPrefix:
+			args = []interface{}{"hash prefix", old.HashPrefix, f.HashPrefix}
+		case f.MetaVersion != old.MetaVersion:
+			args = []interface{}{"meta version", old.MetaVersion, f.MetaVersion}
+		}
+		if args == nil {
+			f.UUID = old.UUID
+		} else {
+			return fmt.Errorf("cannot update volume %s from %v to %v", args...)
+		}
+	}
+	return nil
+}
+
 func (f *Format) RemoveSecret() {
 	if f.SecretKey != "" {
 		f.SecretKey = "removed"

pkg/meta/redis.go

@@ -227,27 +227,8 @@ func (r *redisMeta) Init(format Format, force bool) error {
 		if err != nil {
 			logger.Fatalf("existing format is broken: %s", err)
 		}
-		if force {
-			old.RemoveSecret()
-			logger.Warnf("Existing volume will be overwrited: %+v", old)
-		} else {
-			format.UUID = old.UUID
-			// these can be safely updated.
-			old.Bucket = format.Bucket
-			old.AccessKey = format.AccessKey
-			old.SecretKey = format.SecretKey
-			old.EncryptKey = format.EncryptKey
-			old.KeyEncrypted = format.KeyEncrypted
-			old.Capacity = format.Capacity
-			old.Inodes = format.Inodes
-			old.TrashDays = format.TrashDays
-			old.MinClientVersion = format.MinClientVersion
-			old.MaxClientVersion = format.MaxClientVersion
-			if format != old {
-				old.RemoveSecret()
-				format.RemoveSecret()
-				return fmt.Errorf("cannot update format from %+v to %+v", old, format)
-			}
+		if err = format.update(&old, force); err != nil {
+			return err
 		}
 	}
 

pkg/meta/sql.go

@@ -262,27 +262,8 @@ func (m *dbMeta) Init(format Format, force bool) error {
 		if err != nil {
 			return fmt.Errorf("json: %s", err)
 		}
-		if force {
-			old.RemoveSecret()
-			logger.Warnf("Existing volume will be overwrited: %+v", old)
-		} else {
-			format.UUID = old.UUID
-			// these can be safely updated.
-			old.Bucket = format.Bucket
-			old.AccessKey = format.AccessKey
-			old.SecretKey = format.SecretKey
-			old.EncryptKey = format.EncryptKey
-			old.KeyEncrypted = format.KeyEncrypted
-			old.Capacity = format.Capacity
-			old.Inodes = format.Inodes
-			old.TrashDays = format.TrashDays
-			old.MinClientVersion = format.MinClientVersion
-			old.MaxClientVersion = format.MaxClientVersion
-			if format != old {
-				old.RemoveSecret()
-				format.RemoveSecret()
-				return fmt.Errorf("cannot update format from %+v to %+v", old, format)
-			}
+		if err = format.update(&old, force); err != nil {
+			return err
 		}
 	}
 

pkg/meta/tkv.go

@@ -325,27 +325,8 @@ func (m *kvMeta) Init(format Format, force bool) error {
 		if err != nil {
 			return fmt.Errorf("json: %s", err)
 		}
-		if force {
-			old.RemoveSecret()
-			logger.Warnf("Existing volume will be overwrited: %+v", old)
-		} else {
-			format.UUID = old.UUID
-			// these can be safely updated.
-			old.Bucket = format.Bucket
-			old.AccessKey = format.AccessKey
-			old.SecretKey = format.SecretKey
-			old.EncryptKey = format.EncryptKey
-			old.KeyEncrypted = format.KeyEncrypted
-			old.Capacity = format.Capacity
-			old.Inodes = format.Inodes
-			old.TrashDays = format.TrashDays
-			old.MinClientVersion = format.MinClientVersion
-			old.MaxClientVersion = format.MaxClientVersion
-			if format != old {
-				old.RemoveSecret()
-				format.RemoveSecret()
-				return fmt.Errorf("cannot update format from %+v to %+v", old, format)
-			}
+		if err = format.update(&old, force); err != nil {
+			return err
 		}
 	}