Skip to content

Conversation

@zhijian-pro
Copy link
Contributor

Close #1634

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022

Codecov Report

Merging #1653 (e52b336) into main (5efd718) will increase coverage by 0.10%.
The diff coverage is 77.77%.

❗ Current head e52b336 differs from pull request most recent head b28e82a. Consider uploading reports for the commit b28e82a to get more accurate results

@@            Coverage Diff             @@
##             main    #1653      +/-   ##
==========================================
+ Coverage   61.52%   61.62%   +0.10%     
==========================================
  Files         133      133              
  Lines       22573    22596      +23     
==========================================
+ Hits        13888    13925      +37     
+ Misses       7125     7108      -17     
- Partials     1560     1563       +3     
Impacted Files Coverage Δ
pkg/meta/tkv_tikv.go 60.86% <77.77%> (-1.18%) ⬇️
pkg/sync/config.go 92.30% <0.00%> (-7.70%) ⬇️
pkg/fs/fs.go 76.87% <0.00%> (-0.79%) ⬇️
pkg/chunk/disk_cache.go 80.19% <0.00%> (-0.49%) ⬇️
pkg/meta/sql.go 67.28% <0.00%> (+0.20%) ⬆️
cmd/sync.go 67.62% <0.00%> (+0.81%) ⬆️
pkg/meta/sql_lock.go 74.67% <0.00%> (+2.59%) ⬆️
pkg/sync/sync.go 44.44% <0.00%> (+4.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5efd718...b28e82a. Read the comment docs.

@davies
Copy link
Contributor

davies commented Mar 25, 2022

@zhijian-pro please update the docs

@davies davies merged commit 1547bf1 into main Mar 28, 2022
@davies davies deleted the support_tikv_tls branch March 28, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support tls for tikv

4 participants