Skip to content

Conversation

@zhijian-pro
Copy link
Contributor

--bucket format https://${bucketName}.${namespace}.compat.objectstorage.${region}.oraclecloud.com
eg: https://zhijian-test.axntujn0ebjj.compat.objectstorage.ap-singapore-1.oraclecloud.com

@zhijian-pro
Copy link
Contributor Author

#1083

@codecov-commenter
Copy link

Codecov Report

Merging #1516 (9e322e7) into main (d8063a0) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 9e322e7 differs from pull request most recent head d4b4aaf. Consider uploading reports for the commit d4b4aaf to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1516      +/-   ##
==========================================
- Coverage   60.13%   60.12%   -0.02%     
==========================================
  Files         132      132              
  Lines       22189    22195       +6     
==========================================
+ Hits        13344    13345       +1     
- Misses       7283     7293      +10     
+ Partials     1562     1557       -5     
Impacted Files Coverage Δ
pkg/object/s3.go 42.23% <0.00%> (-0.94%) ⬇️
pkg/chunk/cached_store.go 67.35% <0.00%> (-2.07%) ⬇️
pkg/meta/redis.go 71.14% <0.00%> (-0.14%) ⬇️
pkg/meta/sql.go 68.94% <0.00%> (+0.15%) ⬆️
pkg/meta/tkv.go 76.20% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8063a0...d4b4aaf. Read the comment docs.

@zhijian-pro zhijian-pro requested a review from davies March 4, 2022 14:08
// compatible s3
bucketName = hostParts[0]
ep = hostParts[1]
oracleCompile := regexp.MustCompile(`.*\\.compat\\.objectstorage\\.(.*)\\.oraclecloud.com`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oracleRe

@davies davies merged commit 00ddee1 into juicedata:main Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants