Skip to content

Feature Addition: generalize EXTENDS for other prefix-groups (e.g., plugins) and add parameters for ipcluster#546

Open
clearf wants to merge 7 commits intojtriley:developfrom
clearf:develop
Open

Feature Addition: generalize EXTENDS for other prefix-groups (e.g., plugins) and add parameters for ipcluster#546
clearf wants to merge 7 commits intojtriley:developfrom
clearf:develop

Conversation

@clearf
Copy link

@clearf clearf commented Aug 5, 2015

This commit:

  • Reorganizes config.py to generalize extends to other prefixes (to allow, e.g., plugins to extend each other)
    • Add tests to ensure that the use of EXTENDS behaves as expected for a plugin
  • Modified the template config to include examples of EXTENDS in a plugin
  • As an additional note, this PR does not pass all nosetests, but per (http://star.mit.edu/cluster/mlarchives/2700.html), neither do tests run on a clean develop or master branch.

@cancan101
Copy link

This should probably be broken up into two PRs.

@clearf
Copy link
Author

clearf commented Aug 5, 2015

OK, I'll split up and rebase. Good point.

@clearf
Copy link
Author

clearf commented Aug 5, 2015

@cancan101 OK, I took out the ipcluster changes, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants