Add flow Union tests for no-unused-prop-types and prop-types with import
#1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Nov 24, 2017
Contributor
Author
|
Thank you @ljharb ! This is my first time contributing to this package. What is your procedure/requirement/schedule for cutting |
Contributor
Author
|
Thanks for the awesome work @ljharb . This package is amazing. |
Member
|
Only @yannickcr can publish a release; we'll have to wait for them to do so. |
Contributor
Author
|
In that case, thank you to @yannickcr for this awesome plugin too. |
Contributor
Author
|
@yannickcr Can you cut a release? |
Member
|
Hi @justinanastos, thanks for your contribution ❤️ and sorry for the delay. I'm working on a new release and it should be out soon. I will also work with @ljharb to avoid theses long delay between release. |
Contributor
Author
|
No need to apologize @yannickcr ! Thanks for building a great tool that thousands of people use every day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note this only tests that using
importandUnionpropTypes won't crash eslint. This does not actually test that the propTypes are not unused or that they are defined when used.Contributes to issue #1468