Skip to content

added configurable maximum recursion depth #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2014
Merged

added configurable maximum recursion depth #92

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43e6b77
added configurable maximum recursion depth
VSilantyev Feb 12, 2014
ac13166
https://github.com/justinrainbow/json-schema/pull/92
VSilantyev Mar 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/JsonSchema/RefResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ class RefResolver
* @var integer
*/
protected static $depth = 0;
/**
Copy link
Collaborator

@justinrainbow justinrainbow Mar 2, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the indentation on these lines? Also add a \n before this line?

* maximum references depth
* @var integer
*/
public static $maxDepth = 7;

/**
* @var UriRetrieverInterface
Expand Down Expand Up @@ -88,7 +93,7 @@ public function getUriRetriever()
*/
public function resolve($schema, $sourceUri = null)
{
if (self::$depth > 7) {
if (self::$depth > self::$maxDepth) {
return;
}
++self::$depth;
Expand Down