Add *Of properties to RefResolver #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RefResolver currently skips any part of the schema that contains 'allOf', 'anyOf' or 'oneOf'. This prevents proper resolving of references ($ref) that are inside of an array that is part of the above mentioned properties. Add the three property names to the array that is used to execute resolveArrayOfSchemas().
In JsonSchema\Tests\RefResolverTest::testResolve the JsonSchema\RefResolver::resolveArrayOfSchemas method is now called 7 instead of 4 times due to the addition of 'oneOf', 'allOf' and 'anyOf'. Change expected count from 4 to 7 in resolveProvider.
|
👍 |
|
Great job ! We need this 👍 ping @justinrainbow |
|
👍 |
|
Good improvement. |
|
We need it! |
justinrainbow
added a commit
that referenced
this pull request
Dec 7, 2013
Add *Of properties to RefResolver
hakre
pushed a commit
to hakre/json-schema
that referenced
this pull request
Mar 26, 2015
Add *Of properties to RefResolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RefResolver currently skips any part of the schema that contains
'allOf', 'anyOf' or 'oneOf'. This prevents proper resolving of
references ($ref) that are inside of an array that is part of the above
mentioned properties.
Add the three property names to the array that is used to execute
resolveArrayOfSchemas().